Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sgx: use sgx-sdk-demo app instead of busybox #1464

Merged
merged 2 commits into from
Jul 26, 2023
Merged

sgx: use sgx-sdk-demo app instead of busybox #1464

merged 2 commits into from
Jul 26, 2023

Conversation

hj-johannes-lee
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee commented Jun 28, 2023

Busybox does not run anything inside the container, and it does not test with real resources. Use sgx-sdk-demo image instead.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #1464 (4aa7175) into main (91d826f) will not change coverage.
The diff coverage is n/a.

❗ Current head 4aa7175 differs from pull request most recent head 5ff6137. Consider uploading reports for the commit 5ff6137 to get more accurate results

@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files          43       43           
  Lines        4884     4884           
=======================================
  Hits         2444     2444           
  Misses       2301     2301           
  Partials      139      139           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mythi
Copy link
Contributor

mythi commented Jul 21, 2023

one additional request: update sgx-sdk-demo to 2.20 SDK and 1.17 DCAP

@hj-johannes-lee
Copy link
Contributor Author

@mythi updated!

@mythi
Copy link
Contributor

mythi commented Jul 26, 2023

Thanks! Could you do the same for the aesmd image. Ready to move away from draft?

@mythi
Copy link
Contributor

mythi commented Jul 26, 2023

Nevermind, there is nothing version related in it

@hj-johannes-lee hj-johannes-lee marked this pull request as ready for review July 26, 2023 16:36
@hj-johannes-lee hj-johannes-lee requested a review from tkatila as a code owner July 26, 2023 16:36
@mythi mythi merged commit c7feb2d into intel:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants