Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator to support image with sha256 tags through env vars #1873

Closed
hj-johannes-lee opened this issue Oct 7, 2024 · 0 comments · Fixed by #1865
Closed

Fix operator to support image with sha256 tags through env vars #1873

hj-johannes-lee opened this issue Oct 7, 2024 · 0 comments · Fixed by #1865
Assignees

Comments

@hj-johannes-lee
Copy link
Contributor

hj-johannes-lee commented Oct 7, 2024

Describe the bug
Operatorhub bundle can have sha256 image tags that are put through env vars. When operator controller manager gets upgraded, its operands (plugin daemonsets) should be updated to the image in the env vars. But it has not been working properly because of wrong parsing.

To Reproduce
Steps to reproduce the behavior:
Follow the part that installs olm and deploys operator using operatorhub bundle in DEVEL.md. Deploy one plugin and then upgrade the bundle with

# for example, qat plugin
kubectl apply -k deployments/operator/samples/deviceplugin_v1_qatdeviceplugin.yaml
operator-sdk run bundle-upgrade <bundle image name> -n testoperator

You will see the operator gets upgraded, but plugin remains the same.

Expected behavior
The plugin deployed before the upgrade should be upgraded together with the operator to run the image in the env vars.

Screenshots

System (please complete the following information):

  • OS version: Ubuntu 24.04
  • Kernel version: Linux 6.11
  • Device plugins version: v0.29.0-v0.31.0
  • Hardware info: SPR with QAT

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant