From db58cd58bc0919e7904cb12985eb30f9c530aa46 Mon Sep 17 00:00:00 2001 From: Mikko Ylinen Date: Fri, 3 Feb 2023 11:58:00 +0200 Subject: [PATCH 1/4] build: move to Go 1.20 Signed-off-by: Mikko Ylinen --- .github/workflows/ci.yaml | 2 +- Jenkinsfile | 2 +- Makefile | 2 +- build/docker/intel-deviceplugin-operator.Dockerfile | 2 +- build/docker/intel-dlb-initcontainer.Dockerfile | 2 +- build/docker/intel-dlb-plugin.Dockerfile | 2 +- build/docker/intel-dsa-plugin.Dockerfile | 2 +- build/docker/intel-fpga-admissionwebhook.Dockerfile | 2 +- build/docker/intel-fpga-initcontainer.Dockerfile | 2 +- build/docker/intel-fpga-plugin.Dockerfile | 2 +- build/docker/intel-gpu-fakedev.Dockerfile | 2 +- build/docker/intel-gpu-initcontainer.Dockerfile | 2 +- build/docker/intel-gpu-plugin.Dockerfile | 2 +- build/docker/intel-iaa-plugin.Dockerfile | 2 +- build/docker/intel-qat-initcontainer.Dockerfile | 2 +- build/docker/intel-qat-plugin-kerneldrv.Dockerfile | 2 +- build/docker/intel-qat-plugin.Dockerfile | 2 +- build/docker/intel-sgx-admissionwebhook.Dockerfile | 2 +- build/docker/intel-sgx-initcontainer.Dockerfile | 2 +- build/docker/intel-sgx-plugin.Dockerfile | 2 +- build/docker/intel-vpu-plugin.Dockerfile | 2 +- build/docker/intel-xpumanager-sidecar.Dockerfile | 2 +- build/docker/lib/golang_base.docker | 2 +- go.mod | 2 +- 24 files changed, 24 insertions(+), 24 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 728885eb4..ae3fdaadb 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,7 +9,7 @@ on: - main - 'release-*' env: - GO_VERSION: 1.19 + GO_VERSION: 1.20 K8S_VERSION: 1.25.0 permissions: contents: read diff --git a/Jenkinsfile b/Jenkinsfile index c7131103e..de6e43810 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -10,7 +10,7 @@ pipeline { REG="cloud-native-image-registry.westus.cloudapp.azure.com/" K8S_VERSION="1.25.0" GOLANGCI_LINT_VERSION="v1.50.0" - GO_VERSION="1.19" + GO_VERSION="1.20" GO_TAR="go${GO_VERSION}.linux-amd64.tar.gz" GOROOT="/usr/local/go" GOPATH="/tmp/go" diff --git a/Makefile b/Makefile index 5520e6467..4feac3e12 100644 --- a/Makefile +++ b/Makefile @@ -174,7 +174,7 @@ terrascan: pre-pull: ifeq ($(TAG),devel) - @$(BUILDER) pull golang:1.19-bullseye + @$(BUILDER) pull golang:1.20-bullseye @$(BUILDER) pull debian:unstable-slim @$(BUILDER) pull ubuntu:22.04 endif diff --git a/build/docker/intel-deviceplugin-operator.Dockerfile b/build/docker/intel-deviceplugin-operator.Dockerfile index 784d45fa7..fd0bf2585 100644 --- a/build/docker/intel-deviceplugin-operator.Dockerfile +++ b/build/docker/intel-deviceplugin-operator.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-dlb-initcontainer.Dockerfile b/build/docker/intel-dlb-initcontainer.Dockerfile index 917390acd..47d16d28c 100644 --- a/build/docker/intel-dlb-initcontainer.Dockerfile +++ b/build/docker/intel-dlb-initcontainer.Dockerfile @@ -33,7 +33,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-dlb-plugin.Dockerfile b/build/docker/intel-dlb-plugin.Dockerfile index 831191174..fad7f6412 100644 --- a/build/docker/intel-dlb-plugin.Dockerfile +++ b/build/docker/intel-dlb-plugin.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-dsa-plugin.Dockerfile b/build/docker/intel-dsa-plugin.Dockerfile index c9e2ed86e..f2e85ca86 100644 --- a/build/docker/intel-dsa-plugin.Dockerfile +++ b/build/docker/intel-dsa-plugin.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-fpga-admissionwebhook.Dockerfile b/build/docker/intel-fpga-admissionwebhook.Dockerfile index 22c4f6e10..7c5e5461f 100644 --- a/build/docker/intel-fpga-admissionwebhook.Dockerfile +++ b/build/docker/intel-fpga-admissionwebhook.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-fpga-initcontainer.Dockerfile b/build/docker/intel-fpga-initcontainer.Dockerfile index b64fde991..143e9f885 100644 --- a/build/docker/intel-fpga-initcontainer.Dockerfile +++ b/build/docker/intel-fpga-initcontainer.Dockerfile @@ -33,7 +33,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-fpga-plugin.Dockerfile b/build/docker/intel-fpga-plugin.Dockerfile index ec21ffb83..81eb9276c 100644 --- a/build/docker/intel-fpga-plugin.Dockerfile +++ b/build/docker/intel-fpga-plugin.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-gpu-fakedev.Dockerfile b/build/docker/intel-gpu-fakedev.Dockerfile index a7b00a5e4..4a77170b7 100644 --- a/build/docker/intel-gpu-fakedev.Dockerfile +++ b/build/docker/intel-gpu-fakedev.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-gpu-initcontainer.Dockerfile b/build/docker/intel-gpu-initcontainer.Dockerfile index 7c62beee8..b975e0453 100644 --- a/build/docker/intel-gpu-initcontainer.Dockerfile +++ b/build/docker/intel-gpu-initcontainer.Dockerfile @@ -33,7 +33,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-gpu-plugin.Dockerfile b/build/docker/intel-gpu-plugin.Dockerfile index 32be6d6df..3d6666b9b 100644 --- a/build/docker/intel-gpu-plugin.Dockerfile +++ b/build/docker/intel-gpu-plugin.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-iaa-plugin.Dockerfile b/build/docker/intel-iaa-plugin.Dockerfile index e14b6da68..809cb7a22 100644 --- a/build/docker/intel-iaa-plugin.Dockerfile +++ b/build/docker/intel-iaa-plugin.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-qat-initcontainer.Dockerfile b/build/docker/intel-qat-initcontainer.Dockerfile index 19204b967..198489d99 100644 --- a/build/docker/intel-qat-initcontainer.Dockerfile +++ b/build/docker/intel-qat-initcontainer.Dockerfile @@ -33,7 +33,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-qat-plugin-kerneldrv.Dockerfile b/build/docker/intel-qat-plugin-kerneldrv.Dockerfile index 7e6317da8..2c02257cd 100644 --- a/build/docker/intel-qat-plugin-kerneldrv.Dockerfile +++ b/build/docker/intel-qat-plugin-kerneldrv.Dockerfile @@ -33,7 +33,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-qat-plugin.Dockerfile b/build/docker/intel-qat-plugin.Dockerfile index 4425ea1d0..29b3d589e 100644 --- a/build/docker/intel-qat-plugin.Dockerfile +++ b/build/docker/intel-qat-plugin.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-sgx-admissionwebhook.Dockerfile b/build/docker/intel-sgx-admissionwebhook.Dockerfile index b557b14e9..353acb72f 100644 --- a/build/docker/intel-sgx-admissionwebhook.Dockerfile +++ b/build/docker/intel-sgx-admissionwebhook.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-sgx-initcontainer.Dockerfile b/build/docker/intel-sgx-initcontainer.Dockerfile index 01849f59c..3a8f8547a 100644 --- a/build/docker/intel-sgx-initcontainer.Dockerfile +++ b/build/docker/intel-sgx-initcontainer.Dockerfile @@ -33,7 +33,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-sgx-plugin.Dockerfile b/build/docker/intel-sgx-plugin.Dockerfile index 2ccccdf1e..035f24ab0 100644 --- a/build/docker/intel-sgx-plugin.Dockerfile +++ b/build/docker/intel-sgx-plugin.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-vpu-plugin.Dockerfile b/build/docker/intel-vpu-plugin.Dockerfile index 77ed37db4..4667c4a50 100644 --- a/build/docker/intel-vpu-plugin.Dockerfile +++ b/build/docker/intel-vpu-plugin.Dockerfile @@ -33,7 +33,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/intel-xpumanager-sidecar.Dockerfile b/build/docker/intel-xpumanager-sidecar.Dockerfile index 800ba6324..e2343e737 100644 --- a/build/docker/intel-xpumanager-sidecar.Dockerfile +++ b/build/docker/intel-xpumanager-sidecar.Dockerfile @@ -34,7 +34,7 @@ ARG FINAL_BASE=registry.access.redhat.com/ubi8-micro:latest ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### FROM ${GOLANG_BASE} as builder ARG DIR=/intel-device-plugins-for-kubernetes diff --git a/build/docker/lib/golang_base.docker b/build/docker/lib/golang_base.docker index 854d1e31e..010778f3a 100644 --- a/build/docker/lib/golang_base.docker +++ b/build/docker/lib/golang_base.docker @@ -5,5 +5,5 @@ ## ## This is used on release branches before tagging a stable version. ## The main branch defaults to using the latest Golang base image. -ARG GOLANG_BASE=golang:1.19-bullseye +ARG GOLANG_BASE=golang:1.20-bullseye ### diff --git a/go.mod b/go.mod index a38f222a5..104c68d50 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/intel/intel-device-plugins-for-kubernetes -go 1.18 +go 1.20 require ( github.com/fsnotify/fsnotify v1.6.0 From 6c7804b1e03902228307fe48cc66975c3be662ba Mon Sep 17 00:00:00 2001 From: Hyeongju Johannes Lee Date: Mon, 20 Mar 2023 05:50:59 -0700 Subject: [PATCH 2/4] Update golang-lint to 1.52.1 and fix newly found errors Signed-off-by: Hyeongju Johannes Lee --- .github/workflows/ci.yaml | 2 +- .golangci.yml | 4 ++++ Jenkinsfile | 2 +- Makefile | 2 +- cmd/vpu_plugin/vpu_plugin_test.go | 4 ++-- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ae3fdaadb..7a144adf4 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -58,7 +58,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v3 with: - version: v1.50.0 + version: v1.52.1 args: -v --timeout 5m build: diff --git a/.golangci.yml b/.golangci.yml index 92ca0c4c0..319f78d02 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -41,6 +41,10 @@ linters: - wsl linters-settings: + revive: + rules: + - name: unused-parameter + disabled: true gofmt: simplify: true golint: diff --git a/Jenkinsfile b/Jenkinsfile index de6e43810..124980dde 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -9,7 +9,7 @@ pipeline { GO111MODULE="on" REG="cloud-native-image-registry.westus.cloudapp.azure.com/" K8S_VERSION="1.25.0" - GOLANGCI_LINT_VERSION="v1.50.0" + GOLANGCI_LINT_VERSION="v1.52.1" GO_VERSION="1.20" GO_TAR="go${GO_VERSION}.linux-amd64.tar.gz" GOROOT="/usr/local/go" diff --git a/Makefile b/Makefile index 4feac3e12..998f4111d 100644 --- a/Makefile +++ b/Makefile @@ -10,7 +10,7 @@ EXTRA_BUILD_ARGS ?= "" CERT_MANAGER_VERSION ?= v1.11.0 CONTROLLER_GEN_VERSION ?= v0.11.3 -GOLANGCI_LINT_VERSION ?= v1.50.1 +GOLANGCI_LINT_VERSION ?= v1.52.1 KIND_VERSION ?= v0.17.0 GOLICENSES_VERSION ?= v1.6.0 # Default bundle image tag diff --git a/cmd/vpu_plugin/vpu_plugin_test.go b/cmd/vpu_plugin/vpu_plugin_test.go index 06cb3411e..7b7d72401 100644 --- a/cmd/vpu_plugin/vpu_plugin_test.go +++ b/cmd/vpu_plugin/vpu_plugin_test.go @@ -62,12 +62,12 @@ func createDevice(pciBusRootDir string, bdf string, vid string, pid string) erro vidHex := append([]byte(vid), 0xa) pidHex := append([]byte(pid), 0xa) - err = os.WriteFile(filepath.Join(pciBusRootDir, bdf, "vendor"), vidHex, 0444) + err = os.WriteFile(filepath.Join(pciBusRootDir, bdf, "vendor"), vidHex, 0400) if err != nil { return err } - err = os.WriteFile(filepath.Join(pciBusRootDir, bdf, "device"), pidHex, 0444) + err = os.WriteFile(filepath.Join(pciBusRootDir, bdf, "device"), pidHex, 0400) if err != nil { return err } From 3c06e74365fbe5b8e302c6e46f145e546ba3bb88 Mon Sep 17 00:00:00 2001 From: Hyeongju Johannes Lee Date: Wed, 22 Mar 2023 15:17:17 +0200 Subject: [PATCH 3/4] CI, Jenkinsfile: update envtest's k8s verison to 1.26.1 --- .github/workflows/ci.yaml | 2 +- Jenkinsfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 7a144adf4..a0bbcdea6 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -10,7 +10,7 @@ on: - 'release-*' env: GO_VERSION: 1.20 - K8S_VERSION: 1.25.0 + K8S_VERSION: 1.26.1 permissions: contents: read diff --git a/Jenkinsfile b/Jenkinsfile index 124980dde..1f4e8775a 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -8,7 +8,7 @@ pipeline { environment { GO111MODULE="on" REG="cloud-native-image-registry.westus.cloudapp.azure.com/" - K8S_VERSION="1.25.0" + K8S_VERSION="1.26.1" GOLANGCI_LINT_VERSION="v1.52.1" GO_VERSION="1.20" GO_TAR="go${GO_VERSION}.linux-amd64.tar.gz" From 762578bc3f219f93d89c02409c941c1c229a586f Mon Sep 17 00:00:00 2001 From: Hyeongju Johannes Lee Date: Wed, 22 Mar 2023 14:20:04 +0200 Subject: [PATCH 4/4] CI: use go-version-file with go.mod instead of go-version with a env var --- .github/workflows/ci.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a0bbcdea6..19e96fdf2 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,7 +9,6 @@ on: - main - 'release-*' env: - GO_VERSION: 1.20 K8S_VERSION: 1.26.1 permissions: contents: read @@ -49,7 +48,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: - go-version: ${{ env.GO_VERSION }} + go-version-file: go.mod check-latest: true - name: Install build dependencies needed for VPU plugin run: | @@ -68,7 +67,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-go@v4 with: - go-version: ${{ env.GO_VERSION }} + go-version-file: go.mod check-latest: true - name: Check Dockerfiles run: make check-dockerfiles