Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce ruff formatter #4535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slowy07
Copy link

@slowy07 slowy07 commented Oct 28, 2024

related issue: #4534

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tentatively interested in giving this a shot but...

  • I need documentation for new contributors
  • I need to run it in parallel with black and flake8 for a bit to see if they're finding different stuff of interest
  • We need to do some other changes to make sure pyproject.toml works as expected -- last time it resulted in a bunch of build tools breaking because the rest of our config is in setup.py and some tools assume if you have pyproject.toml it's what you need to use.
  • I am completely swamped with other work right now and have barely been allowed to carve out time to handle the "easy" pull requests so unless you're prepared to do a lot of work this one is going to languish for quite some time.

I'm going to approve this to run and see if anything weird happens when it runs so we can decide what to do next, but just be warned that there's a bunch of work that would need to be done before we can really start using ruff to replace the existing linters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants