-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support .arr, support ios/wasm binaries #4521
base: main
Are you sure you want to change the base?
Conversation
Later change as realised some machines use "file" in version_scanner which i had not handled. Fixed "file" method so it also handles WebAssembly and backup python code handles various Mach-O formats and Webassembly via regex in file.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good; thanks for thinking to add this support. Could you add some tests for each signature? Probably the easiest is to add a few tiny mostly-empty archives into test/data (I think our current tests are often metadata + a text file) but you might be able to do some magic with pytest and mock to fake it, or have the test generate the file.
While adding new tests also realised flaw in versionScanner is_executable. Due to its use of 'file' utility it can fail to detect all binary file type that the python regexp supports so as a backup when it fails the file is_binary script is also run to double check for extra binary types that 'file' can miss. |
Approving tests to run again |
Keep updating as new changes are applied to main but long tests continue to fail? |
Updating the branch so that we get the updated longtest config. |
Hi, does someone need to do anything to enable the tests to run again |
Yeah, because of some concern about people overloading our CI jobs I have to re-approve anyone not on a regular contributors list. Let me get those tests running again now. |
Code changes to include .aar in list of zip type files. AAR is an android archive
Binary file signatures for different apple mach_o/universal and arm support.
Binary file signature for WASM binary