Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve janus signature #2691

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Improve janus signature to avoid catching the string 0.1.19 in version 1.1.0

Signed-off-by: Fabrice Fontaine [email protected]

Improve janus signature to avoid catching the string 0.1.19 in version
1.1.0

Signed-off-by: Fabrice Fontaine <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #2691 (a33a7e2) into main (02e4438) will decrease coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2691      +/-   ##
==========================================
- Coverage   82.72%   82.00%   -0.73%     
==========================================
  Files         634      640       +6     
  Lines        9970    10001      +31     
  Branches     1334     1334              
==========================================
- Hits         8248     8201      -47     
- Misses       1383     1454      +71     
- Partials      339      346       +7     
Flag Coverage Δ
longtests 82.00% <ø> (-0.13%) ⬇️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/janus.py 100.00% <ø> (ø)
test/test_data/janus.py 100.00% <ø> (ø)
cve_bin_tool/extractor.py 69.02% <0.00%> (-11.51%) ⬇️
cve_bin_tool/data_sources/osv_source.py 79.43% <0.00%> (-11.22%) ⬇️
test/test_checkers.py 93.87% <0.00%> (-6.13%) ⬇️
cve_bin_tool/version_scanner.py 86.95% <0.00%> (-3.73%) ⬇️
cve_bin_tool/cve_scanner.py 77.90% <0.00%> (-3.49%) ⬇️
test/test_cli.py 85.34% <0.00%> (-2.20%) ⬇️
cve_bin_tool/output_engine/console.py 93.60% <0.00%> (-1.61%) ⬇️
cve_bin_tool/cli.py 66.56% <0.00%> (-1.28%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, although I wonder if we should build some ability to avoid specific false positives in the future in case changing the main version_pattern isn't an option.

@terriko terriko merged commit 059c566 into intel:main Feb 13, 2023
@ffontaine ffontaine deleted the fix-janus-gateway branch February 14, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants