-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpuallocator: fix cpu priority discovery #971
Conversation
The CPU priorities were discovered correctly but not stored in the cpuallocator so they were effectively discarded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
=======================================
Coverage 33.68% 33.69%
=======================================
Files 61 61
Lines 9156 9157 +1
=======================================
+ Hits 3084 3085 +1
Misses 5789 5789
Partials 283 283
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should we have a unit test with a mocked sysfs exercising and verifying this feature, using exclusively the publicly visible interfaces ?
I think we should. But not just for this feature but for the cpuallocator overall. I'd suggest to leave this as a future exercise as we don't currently have any unit test infra in the cpuallocator to quickly add a new testcase like this |
The CPU priorities were discovered correctly but not stored in the cpuallocator so they were effectively discarded.