Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpuallocator: fix cpu priority discovery #971

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jan 18, 2023

The CPU priorities were discovered correctly but not stored in the cpuallocator so they were effectively discarded.

The CPU priorities were discovered correctly but not stored in the
cpuallocator so they were effectively discarded.
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #971 (daa821d) into master (01cf8c2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   33.68%   33.69%           
=======================================
  Files          61       61           
  Lines        9156     9157    +1     
=======================================
+ Hits         3084     3085    +1     
  Misses       5789     5789           
  Partials      283      283           
Impacted Files Coverage Δ
pkg/cpuallocator/allocator.go 48.32% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we have a unit test with a mocked sysfs exercising and verifying this feature, using exclusively the publicly visible interfaces ?

@marquiz
Copy link
Contributor Author

marquiz commented Jan 18, 2023

Should we have a unit test with a mocked sysfs exercising and verifying this feature, using exclusively the publicly visible interfaces ?

I think we should. But not just for this feature but for the cpuallocator overall. I'd suggest to leave this as a future exercise as we don't currently have any unit test infra in the cpuallocator to quickly add a new testcase like this

@jukkar jukkar merged commit 044b244 into intel:master Jan 18, 2023
@marquiz marquiz mentioned this pull request Jan 8, 2024
18 tasks
@marquiz marquiz deleted the fixes/cpu-priority branch September 5, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants