Skip to content

Commit

Permalink
PCI: endpoint: Remove surplus return statement from pci_epf_test_clea…
Browse files Browse the repository at this point in the history
…n_dma_chan()

Remove a surplus return statement from the void function that has been
added in the commit commit 8353813 ("PCI: endpoint: Enable DMA
tests for endpoints with DMA capabilities").

Especially, as an empty return statements at the end of a void functions
serve little purpose.

This fixes the following checkpatch.pl script warning:

  WARNING: void function return statements are not generally useful
  torvalds#296: FILE: drivers/pci/endpoint/functions/pci-epf-test.c:296:
  +	return;
  +}

Link: https://lore.kernel.org/r/20241104133500.GD2504924@rocinante
Signed-off-by: Wang Jiang <[email protected]>
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <[email protected]>
  • Loading branch information
Wang Jiang authored and kwilczynski committed Nov 4, 2024
1 parent f68da9a commit 846dd9c
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/pci/endpoint/functions/pci-epf-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,6 @@ static void pci_epf_test_clean_dma_chan(struct pci_epf_test *epf_test)

dma_release_channel(epf_test->dma_chan_rx);
epf_test->dma_chan_rx = NULL;

return;
}

static void pci_epf_test_print_rate(struct pci_epf_test *epf_test,
Expand Down

0 comments on commit 846dd9c

Please sign in to comment.