-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPML] Implement verifyQuote in QuoteVerifier.scala #5495
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2cbf648
Add verifyQuote in QuoteVerifier.scala
xiangyuT 0fd9199
Move the change to SGXDCAMQuoteVerifierImpl
xiangyuT 1376b02
Add unit test for SGXDCAPQuoteVerifierImpl
xiangyuT 9ddca6c
Merge branch 'main' of https://github.com/xiangyuT/BigDL into VerifyQ…
xiangyuT b0edad7
Move test quote to ftp
xiangyuT 9a124ef
Add an empty line to end of SGXDCAPQuoteVerifierImplSpec.scala
xiangyuT 9ed98ec
Add import Attestation
xiangyuT cc10d55
Move attestation.Attestation to dcap.Attestation
xiangyuT 711ddba
Refine
xiangyuT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,11 +16,25 @@ | |
|
||
package com.intel.analytics.bigdl.ppml.attestation | ||
|
||
import org.apache.logging.log4j.LogManager | ||
|
||
abstract class QuoteVerifier { | ||
|
||
val logger = LogManager.getLogger(getClass) | ||
|
||
def verifyQuote(quote: Array[Byte]): Int = { | ||
1 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add comments for main code block. |
||
try { | ||
val verifyQuoteResult = Attestation.sdkVerifyQuote(quote) | ||
return verifyQuoteResult | ||
} catch { | ||
case e: Exception => | ||
logger.error(s"Failed to verify quote, ${e}") | ||
throw new AttestationRuntimeException("Failed " + | ||
"to verify quote", e) | ||
} | ||
|
||
throw new AttestationRuntimeException("Unexpected workflow when verifying Quote!") | ||
} | ||
|
||
def verifyQuote(quote: Array[Byte], policy: Policy): Int = { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.