Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nano] Remove redundant exposed apis and add basic openvino unit tests #5170

Merged
merged 6 commits into from
Jul 26, 2022
Merged

[Nano] Remove redundant exposed apis and add basic openvino unit tests #5170

merged 6 commits into from
Jul 26, 2022

Conversation

zhentaocc
Copy link
Contributor

@zhentaocc zhentaocc commented Jul 22, 2022

Description

This PR is to fix some unresolved issues in #5115

  1. As mentioned in [Nano]Make OpenVINOModel as public API #5115, we should expose bigdl.nano.openvino.OpenVINOModel only for basic openvino usage.
  2. Add basic unit tests w\o pytorch/tf installed.

1. Why the change?

  1. expose Pytorch/TF APIs in bigdl.nano.openvino is not that reasonable.
  2. We should have UTs to make sure openvino work fine w\o pytorch/tf.

2. User API changes

N/A

3. Summary of the change

  1. Only expose OpenVINOModel in bigdl.nano.openvino
  2. Add UTs for OpenVINOModel usage

4. How to test?

  • Unit test

@zhentaocc zhentaocc changed the title [Nano] Remove duplicate exposed apis and add basic openvino unit tests [Nano] Remove redundant exposed apis and add basic openvino unit tests Jul 25, 2022
@TheaperDeng TheaperDeng merged commit 948db06 into intel:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants