add spark2.4.6 to maven-publish-scala #5138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glorysdj
reviewed
Jul 20, 2022
| @@ -84,6 +85,21 @@ jobs: | |||
| sed -i 's/<artifactId>bigdl-parent-spark_${spark.version}<\/artifactId>/<artifactId>bigdl-parent-spark_3.1.2<\/artifactId>/' scala/assembly/pom.xml | |||
| mvn -Dhttp.proxyHost=${{ secrets.HTTP_PROXY_HOST_2 }} -Dhttp.proxyPort=${{ secrets.HTTP_PROXY_PORT_2 }} -Dhttps.proxyHost=${{ secrets.HTTP_PROXY_HOST_2 }} -Dhttps.proxyPort=${{ secrets.HTTP_PROXY_PORT_3 }} clean deploy -DskipTests -Dspark.version=3.1.2 -DSPARK_PLATFORM=SPARK_3.1 -P spark_3.x --file scala/pom.xml | |||
|
|
|||
| #spark 2.4.6 | |||
| sed -i 's/<artifactId>${spark-version.project}<\/artifactId>/<artifactId>${spark-version.project}-${SPARK_PLATFORM}<\/artifactId>/' scala/dllib/pom.xml | |||
There was a problem hiding this comment.
should cp some copies for the original pom since they need to be modified twice
glorysdj
reviewed
Jul 21, 2022
| @@ -58,8 +63,8 @@ jobs: | |||
| } | |||
| },{ | |||
| "id": "ossrh", | |||
| "username": "${{ secrets.OSSRH_USERNAME }}", | |||
| "password": "${{ secrets.OSSRH_PASSWORD }}", | |||
| "username": "${OSSRH_USERNAME}", | |||
There was a problem hiding this comment.
put this in
env:
like
- name: Do something
env:
FOO_TOKEN: ${{ secrets.FOO_TOKEN }}
run: |
echo "FOO_TOKEN = ${FOO_TOKEN}"
There was a problem hiding this comment.
put this in env:
like
- name: Do something
env:
FOO_TOKEN: ${{ secrets.FOO_TOKEN }}
run: |
echo "FOO_TOKEN = ${FOO_TOKEN}"
test:
- name: Set up OSSRH
env:
OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}
OSSRH_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
run: |
echo "OSSRH_USERNAME = ${OSSRH_USERNAME}"
echo "OSSRH_PASSWORD = ${OSSRH_PASSWORD}"
still can't get it
Run echo "OSSRH_USERNAME = ${OSSRH_USERNAME}"
OSSRH_USERNAME =
OSSRH_PASSWORD =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add spark2.4.6 to maven-publish-scala, currently only spark3.1.2