Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chronos: remove deprecated API from Chronos. #4398

Open
1 of 4 tasks
TheaperDeng opened this issue Apr 12, 2022 · 0 comments
Open
1 of 4 tasks

Chronos: remove deprecated API from Chronos. #4398

TheaperDeng opened this issue Apr 12, 2022 · 0 comments

Comments

@TheaperDeng
Copy link
Contributor

TheaperDeng commented Apr 12, 2022

Remove deprecated API from Chronos

What ?

Deprecated API is now clustered in bigdl.chronos.autots.deprecated. There has been some long dicussion that we need to remove these APIs but no real practise. Recently we are seeing more and more reasons to remove these deprecated APIs.

Why ?

  • Deprecated API relies on TF1, which will not be supported by Chronos.

    • TCN, LSTM, S2S, MTNet, AutoEncoder has now been migrated to TF2, some of them can work under TF1, but not all of them.

    • TF1 has conflict with pytorch-lightining on dependencies and conflict with TF2 on python versions.

  • Deprecated API now only stays in API doc and 1 use-case notebook with not-recommeded tag. Most of its API usage in our source code is limited to bigdl.chronos.autots.deprecated itself.

  • Deprecated API unittest seems to be the most problematic ones in Chronos unittest and keep causing some random freezing(aborting).

How?

We plan to remove deprecated API by 2 steps:

First Step:

Second Step:

  • Delete deprecated API from src

  • Delete deprecated API use-cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant