Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update transaction status to InSidechainBlock after importing block #672

Closed
haerdib opened this issue Mar 10, 2022 · 0 comments · Fixed by #676
Closed

Only update transaction status to InSidechainBlock after importing block #672

haerdib opened this issue Mar 10, 2022 · 0 comments · Fixed by #676
Assignees

Comments

@haerdib
Copy link
Contributor

haerdib commented Mar 10, 2022

Current status:
Upon creating a block and including a specific transaction, the watching client gets notified about the transaction status update InSidechainBlock. However, at this point in time, the block may have been produced, but the state has not yet been updated, nor has the block been broadcasted to other peers.

Task:
Update the transaction status only after importing the block and, therefore, after having updated the state. Otherwise, benchmarking and state queries upon the transaction status change to InSidechainBlock will not return the updated state.

@haerdib haerdib changed the title Only notify about InSidechainBlock Status after importing block Only update transaction status to InSidechainBlock after importing block Mar 10, 2022
@haerdib haerdib self-assigned this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants