Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the enclave be generic over URL? #190

Open
clangenb opened this issue Jul 6, 2023 · 2 comments
Open

Should the enclave be generic over URL? #190

clangenb opened this issue Jul 6, 2023 · 2 comments

Comments

@clangenb
Copy link
Contributor

clangenb commented Jul 6, 2023

If I remember this correctly, we did this because we can't use Strings inside the runtime, but I am not sure if this is the right approach. Maybe we can just use PalletString as we use elsewhere:

pub type PalletString = Vec<u8>;

@brenzi
Copy link
Contributor

brenzi commented Aug 8, 2023

It shouldn't. I think we can define a safe bounded length for the url and use PalletString with BoundedVec

but I'd like the length of the bounded PalletString to be configurable by type argument.
This might make sense to solve together with #155 bounded types

@clangenb
Copy link
Contributor Author

clangenb commented Aug 8, 2023

Alright, makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants