Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add require conversation resolution before merging support to github_branch_protection resource #868

Closed
nantiferov opened this issue Aug 3, 2021 · 1 comment
Labels

Comments

@nantiferov
Copy link

Hi there,

GitHub recently added new rule to branch protection, named Require conversation resolution before merging.
go-github already support it: google/go-github#1945, google/go-github#1959

Would be nice to have it in terraform github_branch_protection resource

@nantiferov
Copy link
Author

nantiferov commented Jan 20, 2022

Afaik this feature was implemented in #904
And supported now by github_branch_protection resource, option require_conversation_resolution
https://github.com/integrations/terraform-provider-github/blob/main/website/docs/r/branch_protection.html.markdown

I will close this issue as done. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants