Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "maintain" and "triage" for repository collaborators #457

Merged

Conversation

breathingdust
Copy link
Contributor

@breathingdust breathingdust commented May 13, 2020

This follows on from the work done by @romaninsh in #421 and adds the test coverage suggested by @anGie44.

More info: #303 (comment)

Output from Acceptance Tests:

--- PASS: TestAccGithubRepositoryCollaborator_caseInsensitive (16.45s)
--- PASS: TestAccGithubRepositoryCollaborator_basic (31.27s)

@ghost ghost added size/M Type: Documentation Improvements or additions to documentation labels May 13, 2020
@anGie44 anGie44 self-assigned this May 13, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks @breathingdust and @romaninsh for your contributions 👍

Output of acceptance tests:

--- PASS: TestAccGithubRepository_createFromTemplate (8.38s)
--- PASS: TestAccGithubRepository_archive (8.45s)
--- PASS: TestAccGithubRepository_templates (11.09s)
--- PASS: TestAccGithubRepository_hasProjects (14.92s)
--- PASS: TestAccGithubRepository_archiveUpdate (15.00s)
--- PASS: TestAccGithubRepository_basic (15.09s)
--- PASS: TestAccGithubRepository_defaultBranch (16.26s)
--- PASS: TestAccGithubRepository_topics (20.71s)
--- PASS: TestAccGithubRepository_autoInitForceNew (23.68s)

@romaninsh
Copy link
Contributor

Thanks for taking over!

@anGie44 anGie44 merged commit 4fcfcd6 into integrations:master May 15, 2020
anGie44 added a commit that referenced this pull request May 15, 2020
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
…all-permissions

Support "maintain" and "triage" for repository collaborators
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants