Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger acceptance test runs from PRs #374

Closed
4 tasks done
jcudit opened this issue Mar 3, 2020 · 2 comments · Fixed by #375
Closed
4 tasks done

Trigger acceptance test runs from PRs #374

jcudit opened this issue Mar 3, 2020 · 2 comments · Fixed by #375
Assignees

Comments

@jcudit
Copy link
Contributor

jcudit commented Mar 3, 2020

New contributors to this repository currently need to run through these instructions before they can validate their changes are safe to merge.

I have been iterating on a branch to provide acceptance testing via a GitHub Action that can be triggered by adding a label with a specific prefix to a PR. Since becoming usable, I have rarely needed to drop to my local setup to run tests.

This issue tracks upstreaming this Action so that the community can trigger tests on their own.

cc https://github.com/terraform-providers/terraform-provider-github/issues/350 (documents flaky tests)
cc https://github.com/terraform-providers/terraform-provider-github/pull/372 (tests require go 1.13)
cc https://github.com/terraformtesting/acceptance-tests


  • Publish branch for review
  • Await the outcome of go 1.13 adoption
  • Add secrets to this repository (requires admin privs)
  • Merge branch
@benj-fletch
Copy link
Contributor

If you haven't planned to already, I would suggest that we enable the acceptance tests to run as a requisite action to be able to merge to master. Thoughts?
(See here for further info https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks)

@jcudit
Copy link
Contributor Author

jcudit commented Mar 5, 2020

I think that is a solid plan long term. I'd like to use them ad-hoc initially to gain more confidence in the stability of the tests. Good call though, I had not considered coupling them to a merge as yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants