Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable binary acceptance test driver #373

Closed
kmoe opened this issue Mar 2, 2020 · 5 comments
Closed

Enable binary acceptance test driver #373

kmoe opened this issue Mar 2, 2020 · 5 comments
Assignees
Labels
Status: Stale Used by stalebot to clean house Type: Feature New feature or request

Comments

@kmoe
Copy link

kmoe commented Mar 2, 2020

Terraform plugin SDK v1.7.0 includes a new binary acceptance test driver feature, which makes acceptance tests runs more realistic by running terraform CLI commands during tests, instead of simulating them using old SDK code.

Please see hashicorp/terraform-plugin-sdk#262 for more details about this feature, and hashicorp/terraform-provider-random#99 for an example of how to switch the feature on.

Parking this ticket here for now, as this needs https://github.com/terraform-providers/terraform-provider-github/pull/372. After https://github.com/terraform-providers/terraform-provider-github/pull/372 is merged I'll submit a PR enabling the binary driver for review.

@kmoe kmoe added the Type: Feature New feature or request label Mar 2, 2020
@kmoe kmoe self-assigned this Mar 2, 2020
@benj-fletch
Copy link
Contributor

benj-fletch commented Mar 6, 2020

Hi @kmoe, thanks a lot for bringing this feature to us, it sounds like a reasonable idea.
#372 has now been merged, so you should be free to go ahead and work on this. 😄

I would also like @jcudit to have sight of this since there is a lot of space being done in the testing area at the moment.

@jcudit
Copy link
Contributor

jcudit commented Mar 6, 2020

Hi @kmoe, please mention me on the PR when it is ready. Happy to help with reviewing and testing the change 😄

@jcudit
Copy link
Contributor

jcudit commented Mar 18, 2020

@kmoe can we align this effort with another one that is in the works? There is a series of PRs that have their tests deferred but are now needed to unblock progress.

Would you be willing to write a few of the missing tests as an example that future contributors can model going forward?

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Dec 9, 2022
@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Dec 10, 2022
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Apr 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants