Bug Fix: Webhook secret stored incorrectly in state

[megan07]

Addressing #171 where the webhook secret set in Terraform makes signatures not match.
Before fix:

--- FAIL: TestAccGithubRepositoryWebhook_importSecret (9.38s)
    testing.go:568: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

        (map[string]string) (len=1) {
         (string) (len=22) "configuration.0.secret": (string) (len=8) "********"
        }


        (map[string]string) (len=1) {
         (string) (len=22) "configuration.0.secret": (string) (len=18) "RandomSecretString"
        }

After fix:

=== RUN   TestAccGithubRepositoryWebhook_importSecret
=== PAUSE TestAccGithubRepositoryWebhook_importSecret
=== CONT  TestAccGithubRepositoryWebhook_importSecret
--- PASS: TestAccGithubRepositoryWebhook_importSecret (9.66s)
PASS

[paddycarver]

I'd love to see a test that the secret actually ends up in state as we expect. Otherwise, this looks reasonable to me.

[paddycarver]

I'm assuming the GitHub API doesn't return the secret, so we have to set it based on what's in the ResourceData? If so, can we add a comment saying as much, just to explain why we have to do this?

[paddycarver]

Also, what does hook.Config get set to, if not nil? That looks like the GitHub response, but what does it actually get set to?

[paddycarver]

Likewise, a comment here just explaining the situation would be 💯

[harlowja]

Ah, this explains why terraform screwed up all of our organizations hook secrets! Can we get this merged....

[zhenkaiwang]

Hope this get reviewed and merged soon 🚀

[wenbin1989]

Hope this get merged ASAP. we have to apply the patch manually currently, which is not very nice.