Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: Missing distinction between roles and permissions #2508

Open
1 task done
stevehipwell opened this issue Dec 6, 2024 · 0 comments
Open
1 task done

[MAINT]: Missing distinction between roles and permissions #2508

stevehipwell opened this issue Dec 6, 2024 · 0 comments
Labels
Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@stevehipwell
Copy link
Contributor

Describe the need

There is currently a function in the provider called getPermission that is being used to convert a role (e.g. read) into a permission (e.g. pull). The validity of this should be investigated as a comparison to the GitHub REST API; for example github_repository_team currently has the permission attribute which is being mapped to the role_name coming back from the REST API while the permissions array data from the REST API are being ignored.

This is relevant to #2498.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@stevehipwell stevehipwell added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Dec 6, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

No branches or pull requests

1 participant