Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: github_team_membership fails to create resource for a team with forward-slashes #2018

Closed
1 task done
rcambrj opened this issue Nov 15, 2023 · 2 comments
Closed
1 task done
Labels
Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@rcambrj
Copy link

rcambrj commented Nov 15, 2023

Expected Behavior

Should attach user to team.
The provider should swap / (forward slashes) for - (hyphens) when issuing GET on the team resource, like so:

https://github.com/orgs/[...]/teams/foo/bar

becomes:

https://github.com/orgs/[...]/teams/foo-bar

Actual Behavior

│ Error: strconv.ParseInt: parsing "foo/bar": invalid syntaxGET https://api.github.com/orgs/[...]/teams/foo/bar: 404 Not Found []
│
│   with module.github.github_team_membership.this["foo-bar"],
│   on github/main.tf line 11, in resource "github_team_membership" "this":
│   11: resource "github_team_membership" "this" {
│

Terraform Version

Terraform v1.5.7
on darwin_amd64
+ provider registry.terraform.io/integrations/github v5.42.0

Affected Resource(s)

  • github_team_membership

Terraform Configuration Files

resource "github_team_membership" "foo-bar" {
  team_id = "foo/bar"
  username = "rcambrj"
  role = "maintainer"
}

Steps to Reproduce

terraform apply

Debug Output

No response

Panic Output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rcambrj rcambrj added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Nov 15, 2023
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Nov 21, 2023
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Nov 21, 2023
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Aug 18, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2024
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

2 participants