Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 1031 (V4.20.1) introduced breaking changes #1190

Closed
david-bain opened this issue Jun 16, 2022 · 1 comment
Closed

PR 1031 (V4.20.1) introduced breaking changes #1190

david-bain opened this issue Jun 16, 2022 · 1 comment

Comments

@david-bain
Copy link
Contributor

Our codebase relied on data github_repository failing when a repo was not found. It is a good way to ensure during plan that a user has not mispelt a repository name.

PR 1031 introduced a change that resulted in just a message being returned if a repo is missing and the plan continuing. This has resulted in our check being effectively bypassed and deployments breaking.

As this is a minor release, could it be fixed that there is an optional flag to continue on missing repos with the default being to error?

@david-bain david-bain changed the title PR 1031 introduced breaking changes PR 1031 (V4.20.1) introduced breaking changes Jun 16, 2022
@david-bain
Copy link
Contributor Author

I wrote around this so it longer is an issue for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant