New Resource: github_repository_project #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Aug 8, 2018
There was a problem hiding this comment.
Thanks for this PR too @shihanng
Without repeating myself here I'm just going to refer to https://github.com/terraform-providers/terraform-provider-github/pull/111 as all my comments/questions apply here as well, except the one about docs.
shihanng
force-pushed
the
repository_project
branch
from
3df58fe to
dd35451
Compare
|
@radeksimko, I've made changes based on your comments:
Could you please have another look? Thank you. |
radeksimko
approved these changes
Aug 10, 2018
There was a problem hiding this comment.
Thanks @shihanng, I just made a few small tweaks (commit messages should be self-explanatory) and pushed these straight to your branch, so we can pull this PR in. I hope you don't mind.
🚢
|
Thank you 🎉 |
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* r/github_repository_project: first commit * r/github_repository_project: add docs * inline struct fields for readability * repository_project: fix import and add test * Clean up var names & fix typo * Improve error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #111, this allow us to create projects on repository level via Terraform.
https://developer.github.com/v3/projects/#create-a-repository-project
I believe this fixes #19.