Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required_pull_request_reviews in github_branch_protection is missing the list of authorized bypass #1080

Closed
jdfischer-cedreo opened this issue Mar 3, 2022 · 3 comments
Labels
Status: Stale Used by stalebot to clean house

Comments

@jdfischer-cedreo
Copy link

Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

Terraform Version

Terraform v0.12.31
provider.github v4.20.0

Affected Resource(s)

  • github_branch_protection

Terraform Configuration Files

resource "github_branch_protection" "test-branch-protection-master" {
  repository_id = github_repository.test-repository.node_id
  pattern = "master**"
  required_pull_request_reviews {
    bypass_pull_request = [
      data.github_user.devtools.node_id,
    ]
  }
}

Expected Behavior

A field to specify the list of user that can bypass pull request. The label in github interface is "Allow specified actors to bypass pull request requirements".

Actual Behavior

No option to do this.

@btkostner
Copy link
Contributor

This was added and released in 4.21.0 #1030

@github-actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Dec 14, 2022
@kfcampbell
Copy link
Member

CLosing as #1030 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house
Projects
None yet
Development

No branches or pull requests

3 participants