Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding merge types to repository resource #1

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Adding merge types to repository resource #1

merged 1 commit into from
Jun 16, 2017

Conversation

taiidani
Copy link

@taiidani taiidani commented Jun 9, 2017

Adding merge types to the GitHub Repository resource so that users can control when the repository allows Squash merges, Rebase merges and/or Merge commits.

Imported from hashicorp/terraform#15230
Fixes hashicorp/terraform#15183
Fixes #14

@josephholsten
Copy link

Copy link

@josephholsten josephholsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems boring an reasonable!

@taiidani
Copy link
Author

Hey -- boring? This was my first contribution to Terraform! Far from boring!

@josephholsten
Copy link

"Exciting" code scares me. I'll take boring any day!

I think we're waiting on the provider migration to finish and then this can get merged.

@stack72
Copy link
Contributor

stack72 commented Jun 16, 2017

Hi @taiidani

Thanks for the work here - I had to make 1 change to the tests. When i ran the tests in their form, I got the following:

=== RUN   TestAccGithubRepository_importBasic
--- FAIL: TestAccGithubRepository_importBasic (0.32s)
	testing.go:428: Step 0 error: Error applying: 1 error(s) occurred:

		* github_repository.foo: 1 error(s) occurred:

		* github_repository.foo: POST https://api.github.com/orgs/terraformtesting/repos: 422 Repository creation failed. [{Resource:Repository Field: Code:custom Message:Either :allow_merge_commit, :allow_squash_merge or :allow_rebase_merge must be true}]

So I updated the tests :)

Thanks

Paul

@stack72 stack72 merged commit 1bbe0ed into integrations:master Jun 16, 2017
jcudit pushed a commit that referenced this pull request Dec 18, 2020
* Added `allowsDeletions`and `allowsForcePushes`settings https://developer.github.com/v4/changelog/2020-11-13-schema-changes/ (#1)

* complete documentation

* update module github.com/shurcooL/githubv4 with `go get github.com/shurcooL/githubv4`

* vendor latest githubv4

* add test for deletions and force pushes

Co-authored-by: Jeremy Udit <[email protected]>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
)

* Added `allowsDeletions`and `allowsForcePushes`settings https://developer.github.com/v4/changelog/2020-11-13-schema-changes/ (integrations#1)

* complete documentation

* update module github.com/shurcooL/githubv4 with `go get github.com/shurcooL/githubv4`

* vendor latest githubv4

* add test for deletions and force pushes

Co-authored-by: Jeremy Udit <[email protected]>
kfcampbell pushed a commit that referenced this pull request Mar 8, 2024
* Adding github_actions_enterprise_permissions (#1)

* Adding enterprise permissions resource

* Working version

* Adding docs

* Functioning tests

* Adding check on integration tests

* Switching to github_enterprise_actions_permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants