Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fails with intake upstream #9

Closed
aaronspring opened this issue Dec 6, 2020 · 3 comments · Fixed by #12
Closed

fails with intake upstream #9

aaronspring opened this issue Dec 6, 2020 · 3 comments · Fixed by #12

Comments

@aaronspring
Copy link
Collaborator

aaronspring commented Dec 6, 2020 •
edited
Loading

in #7 and #8

https://github.com/intake/intake/blob/e7a6da73e539461fecc9b717732d9c88552212ae/intake/catalog/base.py#L392

needs to be not a container? EDIT: container='catalog'
@martindurant
Copy link
Member

Is this intake latest release or master?

intake/intake#548

@aaronspring
Copy link
Collaborator Author

in upstream, intake master is used. the rest of CI uses intake release which works fine.

@aaronspring aaronspring mentioned this issue Dec 8, 2020
Merged
3 tasks
@martindurant
Copy link
Member

Following the merger, feel free to prod me here until I get around to fixing versus Intake master (which ought to be released anyhow).

@martindurant martindurant mentioned this issue Dec 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass kwargs to Catalog martindurant/intake-thredds
2 participants
@martindurant @aaronspring