Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-icons-build): upgrade gulp-iconfont to prevent build issues on OSX Catalina #342

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

matyasf
Copy link
Collaborator

@matyasf matyasf commented Jan 20, 2021

it was using an old version of node-gyp, which had this issue: nodejs/node-gyp#1927
Also not that this package needs Node 12+, but we just moved to that (and its a DEV dependency :)

@matyasf matyasf requested a review from Brailor January 20, 2021 13:20
@matyasf matyasf self-assigned this Jan 20, 2021
@matyasf matyasf added the Icons label Jan 20, 2021
@matyasf matyasf merged commit aedd817 into next Jan 21, 2021
@matyasf matyasf deleted the upgrade-ui-icons branch January 21, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants