Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP HandleFunc / HTTP client tracing simplified #63

Merged
merged 4 commits into from
Apr 5, 2019
Merged

HTTP HandleFunc / HTTP client tracing simplified #63

merged 4 commits into from
Apr 5, 2019

Conversation

noctarius
Copy link
Contributor

Created a simplified way (wrapper / adapter) to handle simple cases like HTTP server handler or HTTP client requests. Other possibilities like SQL, MQ or other things could follow.

@noctarius
Copy link
Contributor Author

PR builder fails due to the fact it tries to resolve github.com/instana/golang-sensor from the current master instead from the commit :(

@pglombardo
Copy link
Contributor

pglombardo commented Feb 26, 2019

Thanks @noctarius! Can you add some documentation on how to use these? Then a pointer to the example app? Maybe on the front README and I'll copy/paste into a docs PR for the go page.

@noctarius
Copy link
Contributor Author

done :)

@steveww
Copy link
Contributor

steveww commented Feb 27, 2019

There is a neater way IMHO to do the handler wrappers, see https://github.com/steveww/go-appd

The wrappers are at the end of appd.go

@noctarius
Copy link
Contributor Author

added :)

@steveww
Copy link
Contributor

steveww commented Mar 6, 2019

Much neater :-)

@noctarius
Copy link
Contributor Author

Screen Shot 2019-03-22 at 15 23 12
fixed it :)

@pglombardo
Copy link
Contributor

Yay I'll test soon and merge - thanks!

@pglombardo
Copy link
Contributor

Tested & looks great. Thanks @noctarius & @steveww!

@pglombardo pglombardo merged commit 8f7babc into instana:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants