Introduce INSTANA_AUTO_PROFILE #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Great initiative! Being able to enable profiling without any code changes might be very handy when you need to understand the app state better and find the reason of sudden metric changes. The autoprofile package also offers a autoprofile.Disable() method that may override the env variable. I'll take over from here 👍
| @@ -82,7 +83,7 @@ func InitSensor(options *Options) { | |||
| sensor = newSensor(options) | |||
|
|
|||
| // enable auto-profiling | |||
| if options.EnableAutoProfile { | |||
| if options.EnableAutoProfile || strings.ToLower(os.Getenv("INSTANA_AUTO_PROFILE")) == "true" { | |||
There was a problem hiding this comment.
I think we could simplify configuration and simply check whether INSTANA_AUTO_PROFILE is set, just like we do with INSTANA_DEBUG.
|
Replaced by #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to activate AutoProfile via the
INSTANA_AUTO_PROFILEenv car, overriding the compiled setup. This also should work to enable AutoProfile with just recompilation and addingINSTANA_AUTO_PROFILE=trueto the environment.