Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build/Test workflow #184

Open
benbromhead opened this issue May 31, 2019 · 0 comments
Open

Build/Test workflow #184

benbromhead opened this issue May 31, 2019 · 0 comments
Assignees
@benbromhead @zegelin
Labels
testing

Comments

@benbromhead
Copy link
Collaborator

Currently we just run unit tests on PR, then on merge to master we do full e2e tests. All via circleci.

With a goal of one day having a master branch that is always green/working.

We should look to having a workflow of PR (unit tests run) -> Review -> Merge to integration testing branch -> merge to master on success.

We can't run e2e tests on PRs due to ability to steal creds from circleci or steal resources from K8s clusters (e.g. bitcoin mining). So we need a manual review before public PRs can be automatically tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbromhead benbromhead

@zegelin zegelin

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benbromhead @zegelin