Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At build time, concat vendor/app scripts and async load in #39

Closed
addyosmani opened this issue May 21, 2016 · 2 comments
Closed

At build time, concat vendor/app scripts and async load in #39

addyosmani opened this issue May 21, 2016 · 2 comments
Assignees

Comments

@addyosmani
Copy link
Collaborator

Basically, over in this: https://github.com/insin/react-hn/blob/master/src/views/index.ejs#L37

We want to concatenate both vendor and app scripts into a single bundle so at build time instead of:

    <script src="build/vendor.js"></script>
    <script src="build/app.js"></script>

We're just doing:

    <script src="build/bundle.js" async></script>

to avoid blocking.

An alternative to this approach would be ignoring concatenation and just focusing on our HTTP/2 story. I haven't deployed HTTP/2 with push support on AppEngine before, but could learn how to do so if we wanted it.

@addyosmani addyosmani self-assigned this May 21, 2016
@insin
Copy link
Owner

insin commented May 21, 2016

IIRC we should be able to disable vendor splitting in the nwb config, and if I'm not recalling correctly, I'll make it possible and publish a new release with that.

@addyosmani
Copy link
Collaborator Author

I might be reading it wrong (probably am!) but couldn't find a way to disable vendor splitting over in https://github.com/insin/nwb/blob/master/docs/Configuration.md#webpack-object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants