From 6fd1a377d42e9a526fbb0fa2ae43af0e3b9c05d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Llu=C3=ADs=20Revilla?= Date: Tue, 12 Nov 2024 10:35:31 +0100 Subject: [PATCH] Module's ui functions are only checked to have the id parameter. All other parameters are not checked and are silently swallowed by ... --- tests/testthat/test-modules.R | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/testthat/test-modules.R b/tests/testthat/test-modules.R index 4e4c1474cb..d2c10a8133 100644 --- a/tests/testthat/test-modules.R +++ b/tests/testthat/test-modules.R @@ -70,11 +70,6 @@ testthat::test_that("module requires ui_args argument to be a list", { testthat::expect_error(module(ui_args = list(1, 2, 3)), "Must have names") }) -testthat::test_that("module throws when ui has data or datasets argument", { - testthat::expect_error(module(ui = function(id, data) NULL)) - testthat::expect_error(module(ui = function(id, datasets) NULL)) -}) - testthat::test_that("module expects ui being a shiny ui module with any argument", { testthat::expect_no_error(module(ui = function(id) NULL)) testthat::expect_no_error(module(ui = function(id, any_argument) NULL))