Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate filter_var argument in tm_g_gh_spaghettiplot #316

Open
donyunardi opened this issue Oct 7, 2024 · 0 comments
Open

Deprecate filter_var argument in tm_g_gh_spaghettiplot #316

donyunardi opened this issue Oct 7, 2024 · 0 comments
Labels
core good first issue Good for newcomers

Comments

@donyunardi
Copy link
Contributor

donyunardi commented Oct 7, 2024 •
edited
Loading

I agree. Also, I don't think we need filter_var parameter for tm_g_gh_spaghettiplot since it's not being used at all in the code. We should remove this.

Originally posted by @donyunardi in #301 (comment)

Summary

filter_var argument is not being used anywhere in the function body of tm_g_gh_spaghettiplot.

Acceptance Criteria

  • Confirm that this is no longer being used.
  • Deprecate filter_var argument using lifecycle
  • Match with other teal packages on how we normally deprecate feature.
@donyunardi donyunardi changed the title I agree. Also, I don't think we need filter_var parameter for tm_g_gh_spaghettiplot since it's not being used at all in the code. We should remove this. Deprecate filter_var argument in tm_g_gh_spaghettiplot Oct 7, 2024
@donyunardi donyunardi added good first issue Good for newcomers core labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@donyunardi