Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Modifying the slot design for the qenv class #70

Open
pawelru opened this issue Sep 16, 2022 · 2 comments
Open

[Suggestion] Modifying the slot design for the qenv class #70

pawelru opened this issue Sep 16, 2022 · 2 comments
Labels

Comments

@pawelru
Copy link
Contributor

pawelru commented Sep 16, 2022

ID should be an attribute of each element of code vector. This would save you assertions of the length between those two and possibly more.

Originally posted by @pawelru in #66 (comment)

@donyunardi donyunardi changed the title ID should be an attribute of each element of code vector Suggestion: Modifying the slot design for the qenv class Oct 28, 2022
@donyunardi donyunardi changed the title Suggestion: Modifying the slot design for the qenv class [Suggestion] Modifying the slot design for the qenv class Oct 28, 2022
@donyunardi
Copy link
Contributor

The class' slots has grown during development and with all the works that has been going in to the feature branch, maybe it'd be best if we reserve this for the next increment.

The team has reviewed this and assigned story point but still need to decide if this is necessary to do.

@gogonzo
Copy link
Contributor

gogonzo commented Dec 4, 2023

same applies to:

  • warnings
  • messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants