Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console output when running graph type of the output #705

Open
pawelru opened this issue Dec 6, 2023 · 1 comment
Open

Console output when running graph type of the output #705

pawelru opened this issue Dec 6, 2023 · 1 comment

Comments

@pawelru
Copy link
Contributor

pawelru commented Dec 6, 2023

Example (copied from the catalog):

ggtheme <- ggplot2::theme(
  panel.grid = ggplot2::element_line(colour = "black", linetype = 3),
  panel.background = ggplot2::element_rect(fill = "white"),
  legend.position = "top",
  axis.text.x = ggplot2::element_text(angle = 22, hjust = 1, vjust = 1)
)
run(mng01, syn_data, dataset = "adlb", ggtheme = ggtheme)

Console output:

r$> ggtheme <- ggplot2::theme(
      panel.grid = ggplot2::element_line(colour = "black", linetype = 
    3),
      panel.background = ggplot2::element_rect(fill = "white"),
      legend.position = "top",
      axis.text.x = ggplot2::element_text(angle = 22, hjust = 1, vjust
     = 1)
    )
    run(mng01, syn_data, dataset = "adlb", ggtheme = ggtheme)
$`Alanine Aminotransferase Measurement`

$`C-Reactive Protein Measurement`

$`Immunoglobulin A Measurement`

attr(,"class")
[1] "gg_list" "list"

This is also observed in the catalog (this could be silenced though)

I think we should avoid putting those debug statements in the console. Plot names are anyway putted inside the plot as a titles.

@clarkliming
Copy link
Contributor

this is not debug information, but the show method for list. for the list we first print its name and then print its content, however its content is a ggplot object so it will only be printed in the current device (plot panel).

I agree that this can be improved, but should not be that urgent. anyway if you save it as some variable it won't get printed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants