Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to combine default reminders with custom reminders in add commands #672

Open
elig0n opened this issue Dec 4, 2023 · 5 comments
Milestone

Comments

@elig0n
Copy link
Contributor

elig0n commented Dec 4, 2023

title

@dbarnett
Copy link
Collaborator

title

Could you update with an example to clarify what you mean by "combine"? That you can specify a default but also be prompted to add other reminders?

Note I'm in the process of fleshing out an actual config file format (#416) with more supported options, and defaults tend to be a much better fit to configure in structured configs vs. cli args. I might leave existing args alone for now, declare them deprecated, and focus on having ways just in config.toml to pick defaults.

@elig0n
Copy link
Contributor Author

elig0n commented Sep 14, 2024

I wanted to set reminders both of the type I set up in google calendars settings and also other non predefined ones, ie custom ones.

in gcalcli:
--default-reminders and --reminder REMINDERS together for the command add

@dbarnett
Copy link
Collaborator

K yeah, I find the --default-reminders flag confusing and after spending some time looking at the mechanics of it I was actually wondering about the same...

Since --default-reminders describes itself as "If no --reminder is given, use the defaults", it can't be combined with other reminders. AFAICT there's also no way to specify default reminders interactively if you didn't include the --default-reminders option on cli. To fix both issues, I'm considering deprecating --default-reminders and instead having a special DEFAULTS value you can use for reminders, to allow you to use that like any other reminders value.

Then you should be able to do --reminder DEFAULTS --reminder '5m sms' to request defaults combined with an explicit SMS reminder, and that'd take care of your needs here, correct?

@elig0n
Copy link
Contributor Author

elig0n commented Sep 18, 2024

Yes indeed.

@elig0n elig0n closed this as completed Oct 2, 2024
@dbarnett dbarnett added this to the 4.5 milestone Oct 2, 2024
@dbarnett
Copy link
Collaborator

dbarnett commented Oct 2, 2024

#760

Wait was this fixed already? My earlier reminders fix was for something else (but I might've fixed how the options combine along the way?).

@dbarnett dbarnett changed the title Add option to combine default reminders with custom reminders Add option to combine default reminders with custom reminders in add commands Oct 4, 2024
@dbarnett dbarnett reopened this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants