Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack2nix doesn't work well with submodules #163

Open
mpickering opened this issue Apr 5, 2019 · 4 comments
Open

stack2nix doesn't work well with submodules #163

mpickering opened this issue Apr 5, 2019 · 4 comments

Comments

@mpickering
Copy link

It seems that stack2nix first tries to clone the master branch for the given repo. This interacts poorly with submodules as they are initialised to the remote on master rather than the given revision.

If the commit you want to use contains submodules which point to a different remote then running stack2nix fails as it can't find the reference.

The way I "fixed" this was to push my branch to the master branch as well but obviously this is not possible in general.

@angerman
Copy link

angerman commented Apr 6, 2019

We've since switched almost exclusively to haskell.nix at iohk. See https://input-output-hk.github.io/haskell.nix/

@mpickering
Copy link
Author

@angerman That's great but hie-nix still uses stack2nix which is where I ran into this issue. If hie-nix started using haskell.nix then this issue doesn't bother me.

@angerman
Copy link

angerman commented Apr 7, 2019

@domenkozar this is now squarely in your court ;-) I tried. Maybe this is a good opportunity for you to finally try haskell.nix and complain about all that’s wrong with it :-)

@domenkozar
Copy link
Contributor

I think we've fixed this bug at some point but could be it's still broken.

Given @mpickering has a workaround I'd rather delay any stack2nix improvements until I find time for haskell.nix and switch my projects to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants