SCP-3129: Fix minAda related bugs #229

sjoerdvisscher · 2022-01-07T17:03:29Z

Sorry for the extra changes in here. The real fixes are

Pre-submit checklist:

Branch
- Tests are provided (if possible)
- Commit sequence broadly makes sense
- Key commits have useful messages
- Relevant tickets are mentioned in commit messages
- Formatting, materialized Nix files, PNG optimization, etc. are updated
PR
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested

plutus-contract/test/Spec/Contract.hs

sjoerdvisscher added 5 commits December 13, 2021 17:12

Update OffChain.hs

4a0d5af

Merge branch 'main' into SCP-3129-fix-adjustUnbalacedTx

479b386

Add changeInitialWalletValue

ed0850c

Add testcase to reproduce the min ada violation after balancing issue

1b4ed5c

Fix no minAda added for outputs without any Ada

8ac3fd0

sjoerdvisscher requested a review from koslambrou January 7, 2022 17:08

koslambrou reviewed Jan 10, 2022

View reviewed changes

plutus-contract/test/Spec/Contract.hs Outdated Show resolved Hide resolved

koslambrou reviewed Jan 10, 2022

View reviewed changes

plutus-contract/test/Spec/Contract.hs Outdated Show resolved Hide resolved

koslambrou approved these changes Jan 10, 2022

View reviewed changes

PR feedback

74015c9

koslambrou approved these changes Jan 10, 2022

View reviewed changes

sjoerdvisscher merged commit 901bbad into main Jan 10, 2022

sjoerdvisscher deleted the SCP-3129-fix-adjustUnbalacedTx branch January 10, 2022 12:03

sjoerdvisscher mentioned this pull request Jan 14, 2022

Adjusting unbalanced transaction doesn't work in certain cases #143

Closed

Provide feedback