Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-ping: fix missplaced unless quiet #3729

Merged
merged 1 commit into from
May 3, 2022

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented May 2, 2022

which prevented cardano-ping to print ping stats in quiet mode.

@jbgi jbgi requested a review from coot as a code owner May 2, 2022 09:45
@jbgi jbgi requested a review from nfrisby May 2, 2022 09:48
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree, this looks like a sound fix for the mistake made in PR #3700

Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

network-mux/tools/cardano-ping.hs Outdated Show resolved Hide resolved
 which prevented cardano-ping to print ping stats in quiet mode.
@jbgi jbgi force-pushed the fixes/cardano-ping-quiet-mode branch from a3fb808 to 04e9487 Compare May 3, 2022 07:46
@newhoggy
Copy link
Contributor

newhoggy commented May 3, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 3, 2022

@iohk-bors iohk-bors bot merged commit ed5db33 into master May 3, 2022
@iohk-bors iohk-bors bot deleted the fixes/cardano-ping-quiet-mode branch May 3, 2022 16:08
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants