Don't wait forever in TokNext TokMustReply #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karknu
force-pushed
the
karknu/chain_wait
branch
from
dd9b161 to
c7e7c52
Compare
mrBliss
approved these changes
Mar 31, 2020
ouroboros-network/src/Ouroboros/Network/Protocol/ChainSync/Codec.hs
Outdated
Show resolved
Hide resolved
dcoutts
approved these changes
Mar 31, 2020
In the (TokNext TokMustReply) state the responder has indicated that it currently doesn't have a new tip for us and we should wait. This patch limits the time we wait to 70s which means that we don't end up waiting forever incase of network problems. This is implemented in the form of a parameter to timeLimitsChainSync in order to get around troublesome testcases in ouroboros-consensus-mock which don't handle any reasonable timeouts.
karknu
force-pushed
the
karknu/chain_wait
branch
from
89dd544 to
3786275
Compare
|
bors merge |
mrBliss
reviewed
Mar 31, 2020
| @@ -209,6 +209,8 @@ run tracers protocolTracers chainDbTracer diffusionTracers diffusionArguments | |||
| nodeKernel | |||
| protocolTracers | |||
| (protocolCodecs (getTopLevelConfig nodeKernel) version) | |||
| (Just 70) -- timeout after waiting this long for the next header | |||
| -- 70s allows for 3 slots (3 * 20s) | |||
4 tasks
iohk-bors bot
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Mar 31, 2020
742: Windows fixes from latest network package r=dcoutts a=dcoutts - [x] sensible pipe buffer size IntersectMBO/ouroboros-network#1876 - [ ] to more reliably connect to the node with multiple clients simultaneously IntersectMBO/ouroboros-network#1881 - [ ] a fix/workaround for the "DNS getting stuck on the second go on windows" problem IntersectMBO/ouroboros-network#1878 - [x] a timeout in the wait case of chain sync IntersectMBO/ouroboros-network#1871 Co-authored-by: Duncan Coutts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the (TokNext TokMustReply) state the responder has indicated that it
currently doesn't have a new tip for us and we should wait.
This patch limits the time we wait to 70s which means that we don't end
up waiting forever incase of network problems.