Add a missing protocol check in the tx submission inbound peer #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Mar 26, 2020
ouroboros-network/src/Ouroboros/Network/TxSubmission/Inbound.hs
Outdated
Show resolved
Hide resolved
coot
approved these changes
Mar 26, 2020
As part of the tx submission inbound peer, throw a protocol exception when a peer sends are more TxIds than what we requested. Fixes issue #1783
dcoutts
force-pushed
the
dcoutts/issue-1783
branch
from
e372886 to
1651bb7
Compare
|
bors merge |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the tx submission inbound peer, throw a protocol exception when a peer sends more
TxIdsthan what we requested.Fixes issue #1783