Fix a race condition in demuxing (IO) #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1729. |
For 0 length SDUs there was a risk that the responder application finished before the ingress thread parsed the header and threw an exception.
coot
approved these changes
Mar 2, 2020
| @@ -101,7 +101,7 @@ smallMiniProtocolLimit = 16*1024 | |||
|
|
|||
| activeTracer :: forall m a. (MonadSay m, Show a) => Tracer m a | |||
| activeTracer = nullTracer | |||
| --activeTracer = showTracing sayTracer | |||
| --activeTracer = showTracing _sayTracer | |||
There was a problem hiding this comment.
no need to change this line ;)
There was a problem hiding this comment.
Agreed, but it is changed to match the current name of the debug function.
There was a problem hiding this comment.
hmm, I don't like this upstream change: _names are reserved for not used identifiers.
There was a problem hiding this comment.
The function is called _sayTracer and it is unused since active tracer is commented out.
But ifdefs is another alternative...
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 0 length SDUs there was a risk that the responder application
finished before the ingress thread parsed the header and threw an exception.