Fix thunks in RealPBFT #1602
Merged
Fix thunks in RealPBFT #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is being stored in the state of the ChainDB, so to pass the NoUnexpectedThunks checks, it has to be strict in its arguments.
|
If we had IntersectMBO/ouroboros-consensus#756, we would have discovered this much sooner. |
|
CI failure (dependency not in master) is because bors still hasn't merged IntersectMBO/cardano-ledger#717 😩 |
|
Oh, right. Come back in a week. |
mrBliss
force-pushed
the
mrBliss/fix-thunks
branch
from
821902c to
0cc6a1d
Compare
intricate
approved these changes
Feb 7, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 7, 2020
1602: Fix thunks in RealPBFT r=mrBliss a=mrBliss This fixes the thunks found by running the RealPBFT consensus tests with the `checktvarinvariant` flag enabled for the `io-sim-classes` package. Co-authored-by: Thomas Winant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the thunks found by running the RealPBFT consensus tests with the
checktvarinvariantflag enabled for theio-sim-classespackage.