Add ability to get past ledger states #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
added
chain db
consensus
mrBliss
approved these changes
Jan 13, 2020
edsko
force-pushed
the
edsko/get-past-ledger
branch
2 times, most recently
from
d8af76c to
e2c54bc
Compare
edsko
force-pushed
the
edsko/get-past-ledger
branch
from
e2c54bc to
4896df7
Compare
|
The first four commits here are #1451, just adds a single commit on top. |
|
bors r+ |
Merge conflict (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 13, 2020
1446: Add ability to get past ledger states r=edsko a=edsko
This also fixes a regression in the tests where non-saturated chains (fewer than `k` blocks) were ruled out; fortunately, this was a regression in the tests only, not in the code. Running 1M tests on the in-memory ledger DB:
```
# cabal run test-storage -- -p InMemory --quickcheck-tests=1000000
Up to date
ouroboros-storage
Storage
LedgerDB
InMemory
Serialisation
ChainSummary: OK (5.80s)
+++ OK, passed 1000000 tests.
Genesis
length: OK (1.21s)
+++ OK, passed 1000000 tests.
current: OK (1.21s)
+++ OK, passed 1000000 tests.
Push
incrementsLength: OK (2.26s)
+++ OK, passed 1000000 tests (64.0082% saturated).
lengthMatchesNumBlocks: OK (2.08s)
+++ OK, passed 1000000 tests (63.9868% saturated).
matchesPolicy: OK (2.38s)
+++ OK, passed 1000000 tests (63.9719% saturated).
expectedLedger: OK (3.02s)
+++ OK, passed 1000000 tests (63.9387% saturated).
pastLedger: OK (3.76s)
+++ OK, passed 1000000 tests:
96.4751% within reach
63.9570% saturated
Rollback
maxRollbackGenesisZero: OK (1.26s)
+++ OK, passed 1000000 tests.
ledgerDbMaxRollback: OK (2.83s)
+++ OK, passed 1000000 tests (63.9984% saturated).
switchSameChain: OK (3.35s)
+++ OK, passed 1000000 tests (63.9431% saturated).
switchMatchesPolicy: OK (3.84s)
+++ OK, passed 1000000 tests (64.0446% saturated).
switchExpectedLedger: OK (4.99s)
+++ OK, passed 1000000 tests (64.0571% saturated).
pastAfterSwitch: OK (5.34s)
+++ OK, passed 1000000 tests:
92.9097% within reach
63.9944% saturated
```
All 14 tests passed (43.35s)
Closes #1440.
Co-authored-by: Edsko de Vries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a regression in the tests where non-saturated chains (fewer than
kblocks) were ruled out; fortunately, this was a regression in the tests only, not in the code. Running 1M tests on the in-memory ledger DB:All 14 tests passed (43.35s)
Closes #1440.