VolatileDB: fix memory leak #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VolatileDB maintains a number of in-memory indices among which:
type SuccessorsIndex blockId = Map (WithOrigin blockId) (Set blockId)
During garbage collection, this index was not being culled correctly: when the
last `blockId` was removed from a `Set`, the empty `Set` was kept in the `Map`
instead of removing the entry altogether.
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 27, 2019
1379: VolatileDB: fix memory leak r=mrBliss a=mrBliss
The VolatileDB maintains a number of in-memory indices among which:
type SuccessorsIndex blockId = Map (WithOrigin blockId) (Set blockId)
During garbage collection, this index was not being culled correctly: when the last `blockId` was removed from a `Set`, the empty `Set` was kept in the `Map` instead of removing the entry altogether.
Co-authored-by: Thomas Winant <[email protected]>
Build failed |
|
Uggh, bors fails because of some CI flakiness |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 27, 2019
1379: VolatileDB: fix memory leak r=mrBliss a=mrBliss
The VolatileDB maintains a number of in-memory indices among which:
type SuccessorsIndex blockId = Map (WithOrigin blockId) (Set blockId)
During garbage collection, this index was not being culled correctly: when the last `blockId` was removed from a `Set`, the empty `Set` was kept in the `Map` instead of removing the entry altogether.
Co-authored-by: Thomas Winant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VolatileDB maintains a number of in-memory indices among which:
During garbage collection, this index was not being culled correctly: when the last
blockIdwas removed from aSet, the emptySetwas kept in theMapinstead of removing the entry altogether.