Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate the default mempool capacity based on the max block size from the ledger #1467

Closed
intricate opened this issue Jan 15, 2020 · 0 comments · Fixed by #1468
Closed

Calculate the default mempool capacity based on the max block size from the ledger #1467

intricate opened this issue Jan 15, 2020 · 0 comments · Fixed by #1468
Assignees
@intricate
Labels
consensus issues related to ouroboros-consensus mempool
Milestone
S5 2020-01-30

Comments

@intricate
Copy link
Contributor

Spoke with @dcoutts about this and he recommended that the default mempool capacity should be around 2-3x the max block size from the ledger. We should also allow this value to be manually overridden.
@intricate intricate added consensus issues related to ouroboros-consensus mempool labels Jan 15, 2020
@intricate intricate self-assigned this Jan 15, 2020
@mrBliss mrBliss added this to the S4 2020-01-16 milestone Jan 15, 2020
@intricate intricate mentioned this issue Jan 15, 2020
Merged
@mrBliss mrBliss modified the milestones: S4 2020-01-16, S5 2020-01-30 Jan 17, 2020
iohk-bors bot added a commit that referenced this issue Jan 22, 2020
@iohk-bors @intricate
Merge #1468
228d787 
1468: Calculate default mempool capacity as 2x the ledger max block size r=mrBliss a=intricate

Closes #1467 

Co-authored-by: Luke Nadur <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in e539f76 Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@intricate intricate

Labels
consensus issues related to ouroboros-consensus mempool
Projects
None yet
Milestone
S5 2020-01-30
Development

Successfully merging a pull request may close this issue.

Calculate default mempool capacity as 2x the ledger max block size IntersectMBO/ouroboros-network
2 participants
@mrBliss @intricate