Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise ledger DB disk snapshot taking policy #1264

Closed
edsko opened this issue Nov 20, 2019 · 4 comments · Fixed by #1518
Closed

Revise ledger DB disk snapshot taking policy #1264

edsko opened this issue Nov 20, 2019 · 4 comments · Fixed by #1518
Assignees
@edsko
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node chain db consensus issues related to ouroboros-consensus enhancement New feature or request ledger db
Milestone
S5 2020-01-30

Comments

@edsko
Copy link
Contributor

edsko commented Nov 20, 2019 •
edited by mrBliss
Loading

We should probably

1. Take a snapshot when the node shuts down Moved to #1387.
2. Adjust it so that when doing bulk sync, we take snapshots faster than once every 12 hours.

It seems that currently we also take a snapshot after replying? Not sure where/how.
@edsko edsko added consensus issues related to ouroboros-consensus chain db ledger db priority medium labels Nov 20, 2019
@edsko edsko added this to the release-node-1.1.0 development milestone Nov 20, 2019
@mrBliss mrBliss added consensus issues related to ouroboros-consensus priority high and removed consensus issues related to ouroboros-consensus priority medium labels Nov 28, 2019
@mrBliss mrBliss modified the milestones: Sprint 1.1.0, Sprint 1.2.0 Nov 28, 2019
@mrBliss mrBliss self-assigned this Dec 9, 2019
@mrBliss mrBliss modified the milestones: S2 2019-12-19, S3 2020-01-02 Dec 18, 2019
@mrBliss mrBliss removed this from the S3 2020-01-02 milestone Jan 2, 2020
@mrBliss
Copy link
Contributor

mrBliss commented Jan 2, 2020

I split off the most important, high priority part of this ticket to #1387.

@mrBliss mrBliss added byron Required for a Byron mainnet: replace the old core nodes with cardano-node enhancement New feature or request priority medium and removed priority medium labels Jan 3, 2020
@mrBliss
Copy link
Contributor

mrBliss commented Jan 3, 2020

Even when an error occurs will a snapshot be taken on shut down. Only in case of a hard shut down while we're bulk syncing is this going to be an issue.

@edsko edsko changed the title Revise ledger DB snapshot taking policy Revise ledger DB disk snapshot taking policy Jan 10, 2020
@edsko edsko mentioned this issue Jan 10, 2020
Closed
@edsko
Copy link
Contributor Author

edsko commented Jan 10, 2020

Note that this ticket is about on-disk snapshots; see #1026 for the in-memory snapshots.

@edsko edsko mentioned this issue Jan 10, 2020
Open
@edsko
Copy link
Contributor Author

edsko commented Jan 13, 2020

Re-prioritizing as high priority due to #1454 (comment) .

@edsko edsko added this to the S5 2020-01-30 milestone Jan 13, 2020
@edsko edsko mentioned this issue Jan 14, 2020
Closed
@mrBliss mrBliss modified the milestones: S5 2020-01-30, S6 2020-02-13 Jan 24, 2020
edsko added a commit that referenced this issue Jan 28, 2020
@edsko
Better ledger DB policy
a198256 
Closes #1456
Closes #1264
@edsko edsko mentioned this issue Jan 28, 2020
Merged
@edsko edsko modified the milestones: S6 2020-02-13, S5 2020-01-30 Jan 28, 2020
@edsko edsko assigned edsko and unassigned mrBliss Jan 28, 2020
edsko added a commit that referenced this issue Jan 28, 2020
@edsko
Better ledger DB policy
0888e03 
Closes #1456
Closes #1264
edsko added a commit that referenced this issue Jan 28, 2020
@edsko
Better ledger DB policy
de90f5b 
Closes #1456
Closes #1264
iohk-bors bot added a commit that referenced this issue Jan 29, 2020
@iohk-bors @edsko
Merge #1518
86941cb 
1518: Better ledger DB policy r=mrBliss a=edsko

Closes #1456
Closes #1264

Co-authored-by: Edsko de Vries <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in #1518 Jan 29, 2020
@iohk-bors iohk-bors bot closed this as completed in 67ec998 Jan 29, 2020
redxaxder pushed a commit that referenced this issue Feb 3, 2020
@edsko @redxaxder
Better ledger DB policy
5cad2cb 
Closes #1456
Closes #1264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsko edsko

Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node chain db consensus issues related to ouroboros-consensus enhancement New feature or request ledger db
Projects
None yet
Milestone
S5 2020-01-30
Development

Successfully merging a pull request may close this issue.

Better ledger DB policy IntersectMBO/ouroboros-network
2 participants
@mrBliss @edsko