Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire Site Removal Event #31

Closed
cjkoepke opened this issue Aug 4, 2021 · 2 comments
Closed

Fire Site Removal Event #31

cjkoepke opened this issue Aug 4, 2021 · 2 comments

Comments

@cjkoepke
Copy link

cjkoepke commented Aug 4, 2021 •
edited
Loading

Right now, if you connect the wallet, then the browser gets a response. However, if a user goes to Whitelisted Sites and removes a site, there is no callback that a website can use to perform an action (i.e. remove cached wallet data).

Suggestion: add an event for onSiteRemoval or something similar to allow browsers to react to this.
@alessandrokonrad
Copy link
Contributor

alessandrokonrad commented Aug 4, 2021 •
edited
Loading

Yep, this was already suggested: #17
I follow mostly this CIP: cardano-foundation/CIPs#88 right now. Events aren't part of the discussion there yet, but we definitely need to get them in (2 custom events already exist in Nami)

@cjkoepke
Copy link
Author

cjkoepke commented Aug 4, 2021

Awesome, I'll close and follow the other ticket. Thanks @alessandrokonrad

@cjkoepke cjkoepke closed this as completed Aug 4, 2021
@rooooooooob rooooooooob mentioned this issue Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjkoepke @alessandrokonrad