Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run benchmarks directly #173

Open
angerman opened this issue Jun 11, 2019 · 5 comments
Open

Run benchmarks directly #173

angerman opened this issue Jun 11, 2019 · 5 comments
Labels
preserved Keep stale bot away

Comments

@angerman
Copy link
Collaborator

With #168, we skipped using cabal to run the tests, we can do the same for benchmarks as well. For the sake of consistency this seems to be the best approach.

@angerman
Copy link
Collaborator Author

@ruhatch are you going to get around to this as well, or should I?

@rvl
Copy link
Contributor

rvl commented Jul 16, 2019

I fixed the benchmarks build in #175. Unlike test suites, it builds the benchmarks, but does not execute them. I think this is good, because there would be a lot of variance when running benchmarks on hydra build slaves.

This is one example of how we execute benchmarks: cardano-foundation/cardano-wallet#531

One thing we could fix is installing benchmarks in $out/bin rather than a path which is different for every component.

@angerman
Copy link
Collaborator Author

One thing we could fix is installing benchmarks in $out/bin rather than a path which is different for every component.

you mean all benchmarks for a package into the same $out?

@ruhatch
Copy link
Contributor

ruhatch commented Aug 27, 2019

@angerman I'm not going to be able to take this one, so removing myself as assignee, sorry!

@ruhatch ruhatch removed their assignment Aug 27, 2019
@stale
Copy link

stale bot commented Sep 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 28, 2022
@hamishmack hamishmack added the preserved Keep stale bot away label Sep 30, 2022
@stale stale bot removed the wontfix label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preserved Keep stale bot away
Projects
None yet
Development

No branches or pull requests

4 participants