Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow empty cost model for create update proposal #4885

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Disallow empty cost model for create update proposal #4885

merged 2 commits into from
Feb 14, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Feb 14, 2023 •
edited
Loading 

$ cardano-cli governance create-update-proposal --epoch 50 --max-block-execution-units '(20000000000,62000000)' --cost-model-file ~/Downloads/cost-model-secp-preprod-mainnet.json --protocol-major-version 8 --protocol-minor-version 0 --genesis-verification-key-file example/genesis-keys/genesis1.vkey --out-file update.proposal
Command failed: governance create-update-proposal  Error: The decoded cost model was empty at: /Users/jky/Downloads/cost-model-secp-preprod-mainnet.json

Resolves #4867

@newhoggy newhoggy marked this pull request as ready for review February 14, 2023 11:59
newhoggy
newhoggy commented Feb 14, 2023
View reviewed changes
cardano-cli/src/Cardano/CLI/Shelley/Run/Governance.hs
@@ -52,8 +57,10 @@ renderShelleyGovernanceError err =
<> " The number of staking keys: " <> textShow numVKeys
<> " and the number of reward amounts: " <> textShow numRwdAmts
<> " are not equivalent."
ShelleyGovernanceCmdCostModelsJsonDecodeErr err' fp ->
"Error decoding cost model: " <> Text.pack err' <> " at: " <> fp
ShelleyGovernanceCmdCostModelsJsonDecodeErr fp err' ->
Copy link
Contributor Author

@newhoggy newhoggy Feb 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapping of the argument order is an unrelated bug fix.

@newhoggy newhoggy force-pushed the newhoggy/disallow-empty-cost-model-for-create-update-proposal branch from 5748462 to d9d7cd4 Compare February 14, 2023 12:03
Jimbo4350
Jimbo4350 reviewed Feb 14, 2023
View reviewed changes
update.proposal Outdated Show resolved Hide resolved
@newhoggy newhoggy force-pushed the newhoggy/disallow-empty-cost-model-for-create-update-proposal branch from d9d7cd4 to 59f6751 Compare February 14, 2023 12:41
@newhoggy newhoggy requested a review from Jimbo4350 February 14, 2023 12:42
@newhoggy
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 14, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit daeae61 into master Feb 14, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/disallow-empty-cost-model-for-create-update-proposal branch February 14, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - cardano-cli should error if provided invalid cost model
2 participants
@newhoggy @Jimbo4350